Differential D17683

Remove recentParticipants from ConpherenceThread
ClosedPublic
Actions

Authored by chad on Apr 13 2017, 8:34 PM.

Details

Reviewers

epriestley

Commits

rP5587abf04c8b: Remove recentParticipants from ConpherenceThread

Summary

We no longer display this any more in the UI, so go ahead and remove the callsites and db column.

Test Plan

New Room, with and without participants.

Diff Detail

Repository

rP Phabricator

Branch

conpherence-editor (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16459
Build 21909: Run Core Tests
Build 21908: arc lint + arc unit

Event Timeline

chad created this revision.Apr 13 2017, 8:34 PM

Herald added a subscriber: Korvin. · View Herald TranscriptApr 13 2017, 8:34 PM

Harbormaster completed remote builds in B16459: Diff 42528.Apr 13 2017, 8:35 PM

epriestley accepted this revision.Apr 13 2017, 8:41 PM

This revision is now accepted and ready to land.Apr 13 2017, 8:41 PM

Closed by commit rP5587abf04c8b: Remove recentParticipants from ConpherenceThread (authored by chad, committed by chad). · Explain WhyApr 13 2017, 8:55 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D17732: Fix improper filtering behavior in ConpherenceParticipantQuery.Apr 19 2017, 7:52 PM

epriestley mentioned this in rPf46263903cbe: Fix improper filtering behavior in ConpherenceParticipantQuery.Apr 19 2017, 8:59 PM

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20170413.conpherence.01.recentparty.sql

2 lines

src/

applications/

conpherence/

__tests__/

ConpherenceRoomTestCase.php

17 lines

conduit/

ConpherenceQueryThreadConduitAPIMethod.php

1 line

controller/

ConpherenceColumnViewController.php

1 line

ConpherenceListController.php

1 line

ConpherenceNotificationPanelController.php

1 line

ConpherenceUpdateController.php

2 lines

ConpherenceViewController.php

1 line

editor/

ConpherenceEditor.php

41 lines

query/

ConpherenceThreadQuery.php

9 lines

ConpherenceThreadSearchEngine.php

11 lines

storage/

ConpherenceThread.php

72 lines

search/

menuitem/

PhabricatorConpherenceProfileMenuItem.php

1 line

Diff 42528

View Options

resources/sql/autopatches/20170413.conpherence.01.recentparty.sql

View Options

src/applications/conpherence/tests/ConpherenceRoomTestCase.php

View Options

src/applications/conpherence/conduit/ConpherenceQueryThreadConduitAPIMethod.php

View Options

src/applications/conpherence/controller/ConpherenceColumnViewController.php

View Options

src/applications/conpherence/controller/ConpherenceListController.php

View Options

src/applications/conpherence/controller/ConpherenceNotificationPanelController.php

View Options

src/applications/conpherence/controller/ConpherenceUpdateController.php

View Options

src/applications/conpherence/controller/ConpherenceViewController.php

View Options

src/applications/conpherence/editor/ConpherenceEditor.php

View Options

src/applications/conpherence/query/ConpherenceThreadQuery.php

View Options

src/applications/conpherence/query/ConpherenceThreadSearchEngine.php

View Options

src/applications/conpherence/storage/ConpherenceThread.php

View Options

src/applications/search/menuitem/PhabricatorConpherenceProfileMenuItem.php

Remove recentParticipants from ConpherenceThreadClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42528

resources/sql/autopatches/20170413.conpherence.01.recentparty.sql

src/applications/conpherence/__tests__/ConpherenceRoomTestCase.php

src/applications/conpherence/conduit/ConpherenceQueryThreadConduitAPIMethod.php

src/applications/conpherence/controller/ConpherenceColumnViewController.php

src/applications/conpherence/controller/ConpherenceListController.php

src/applications/conpherence/controller/ConpherenceNotificationPanelController.php

src/applications/conpherence/controller/ConpherenceUpdateController.php

src/applications/conpherence/controller/ConpherenceViewController.php

src/applications/conpherence/editor/ConpherenceEditor.php

src/applications/conpherence/query/ConpherenceThreadQuery.php

src/applications/conpherence/query/ConpherenceThreadSearchEngine.php

src/applications/conpherence/storage/ConpherenceThread.php

src/applications/search/menuitem/PhabricatorConpherenceProfileMenuItem.php

Remove recentParticipants from ConpherenceThread
ClosedPublic
Actions

Revision Contents
Changeset List

src/applications/conpherence/tests/ConpherenceRoomTestCase.php