Differential D17682

Change syntax highlighting for custom phabricator dot configs
ClosedPublic
Actions

Authored by amckinley on Apr 13 2017, 8:23 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T11667: Default global syntax.filemap sets default filetypes to JavaScript for JSON configurations

Commits

rPbfffd807d645: Change syntax highlighting for custom phabricator dot configs

Test Plan

Created new paste with title '.arcconfig' without choosing a language; observed that the paste gets highlighted as JSON.

JSON mode:

Screen Shot 2017-04-13 at 1.21.28 PM.png (588×1 px, 66 KB)

Javascript mode:

Screen Shot 2017-04-13 at 1.22.14 PM.png (626×996 px, 66 KB)

Diff Detail

Repository

rP Phabricator

Branch

T11667 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16458
Build 21907: Run Core Tests
Build 21906: arc lint + arc unit

Event Timeline

amckinley created this revision.Apr 13 2017, 8:23 PM

Herald added a subscriber: Korvin. · View Herald TranscriptApr 13 2017, 8:23 PM

Harbormaster completed remote builds in B16458: Diff 42527.Apr 13 2017, 8:24 PM

epriestley accepted this revision.Apr 13 2017, 8:41 PM

This revision is now accepted and ready to land.Apr 13 2017, 8:41 PM

Closed by commit rPbfffd807d645: Change syntax highlighting for custom phabricator dot configs (authored by amckinley, committed by amckinley). · Explain WhyApr 13 2017, 8:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

option/

PhabricatorSyntaxHighlightingConfigOptions.php

6 lines

Diff 42527

View Options

src/applications/config/option/PhabricatorSyntaxHighlightingConfigOptions.php

Change syntax highlighting for custom phabricator dot configsClosedPublicActions