Page MenuHomePhabricator

Provide "bin/files integrity" for debugging, maintaining and backfilling integrity hashes
ClosedPublic

Authored by epriestley on Apr 6 2017, 2:01 PM.
Tags
None
Referenced Files
F15434160: D17629.id42414.diff
Tue, Mar 25, 2:20 AM
F15431773: D17629.id42400.diff
Mon, Mar 24, 2:25 PM
F15427012: D17629.id.diff
Sun, Mar 23, 12:14 PM
F15424310: D17629.diff
Sat, Mar 22, 9:24 PM
F15407125: D17629.id.diff
Tue, Mar 18, 3:53 PM
F15388819: D17629.diff
Sat, Mar 15, 4:27 AM
Unknown Object (File)
Mar 3 2025, 7:06 AM
Unknown Object (File)
Feb 25 2025, 3:52 PM
Subscribers
None

Details

Summary

Ref T12470. Provides an "integrity" utility which runs in these modes:

  • Verify: check that hashes match.
  • Compute: backfill missing hashes.
  • Strip: remove hashes. Useful for upgrading across a hash change.
  • Corrupt: intentionally corrupt hashes. Useful for debugging.
  • Overwrite: force hash recomputation.

Users normally shouldn't need to run any of this stuff, but this provides a reasonable toolkit for managing integrity hashes.

I'll recommend existing installs use bin/files integrity --compute all in the upgrade guidance to backfill hashes for existing files.

Test Plan
  • Ran the script in many modes against various files, saw expected operation, including:
  • Verified a file, corrupted it, saw it fail.
  • Verified a file, stripped it, saw it have no hash.
  • Stripped a file, computed it, got a clean verify.
  • Stripped a file, overwrote it, got a clean verify.
  • Corrupted a file, overwrote it, got a clean verify.
  • Overwrote a file, overwrote again, got a no-op.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable