Page MenuHomePhabricator

Provide "bin/files integrity" for debugging, maintaining and backfilling integrity hashes
ClosedPublic

Authored by epriestley on Apr 6 2017, 2:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 3, 7:06 AM
Unknown Object (File)
Tue, Feb 25, 3:52 PM
Unknown Object (File)
Fri, Feb 21, 3:19 PM
Unknown Object (File)
Feb 9 2025, 3:42 AM
Unknown Object (File)
Feb 9 2025, 3:42 AM
Unknown Object (File)
Feb 9 2025, 3:42 AM
Unknown Object (File)
Feb 9 2025, 3:42 AM
Unknown Object (File)
Jan 31 2025, 4:38 PM
Subscribers
None

Details

Summary

Ref T12470. Provides an "integrity" utility which runs in these modes:

  • Verify: check that hashes match.
  • Compute: backfill missing hashes.
  • Strip: remove hashes. Useful for upgrading across a hash change.
  • Corrupt: intentionally corrupt hashes. Useful for debugging.
  • Overwrite: force hash recomputation.

Users normally shouldn't need to run any of this stuff, but this provides a reasonable toolkit for managing integrity hashes.

I'll recommend existing installs use bin/files integrity --compute all in the upgrade guidance to backfill hashes for existing files.

Test Plan
  • Ran the script in many modes against various files, saw expected operation, including:
  • Verified a file, corrupted it, saw it fail.
  • Verified a file, stripped it, saw it have no hash.
  • Stripped a file, computed it, got a clean verify.
  • Stripped a file, overwrote it, got a clean verify.
  • Corrupted a file, overwrote it, got a clean verify.
  • Overwrote a file, overwrote again, got a no-op.

Diff Detail

Repository
rP Phabricator
Branch
files20
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16329
Build 21711: Run Core Tests
Build 21710: arc lint + arc unit