Page MenuHomePhabricator

Support "Range: bytes=123-" requests
ClosedPublic

Authored by epriestley on Apr 5 2017, 6:05 PM.
Tags
None
Referenced Files
F15408683: D17626.id.diff
Wed, Mar 19, 12:47 AM
F15402714: D17626.diff
Mon, Mar 17, 11:55 PM
F15400761: D17626.id.diff
Mon, Mar 17, 1:54 PM
F15377920: D17626.diff
Thu, Mar 13, 11:25 AM
Unknown Object (File)
Mon, Mar 3, 5:22 AM
Unknown Object (File)
Fri, Feb 21, 3:18 PM
Unknown Object (File)
Tue, Feb 18, 11:48 AM
Unknown Object (File)
Feb 17 2025, 1:47 AM
Subscribers
None

Details

Summary

Ref T12219. We currently only support Range requests like "bytes=123-456", but "bytes=123-", meaning "until end of file", is valid, and Chrome can send these requests.

I suspect this is the issue with T12219.

Test Plan

Used nc local.phacility.com 80 to pipe raw requests, saw both "bytes=123-456" and "bytes=123-" requests satisfied correctly.

Diff Detail

Repository
rP Phabricator
Branch
files16
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16322
Build 21701: Run Core Tests
Build 21700: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Apr 5 2017, 6:24 PM
This revision was automatically updated to reflect the committed changes.