Page MenuHomePhabricator
Differential D17626

Support "Range: bytes=123-" requests
ClosedPublic
Actions

Authored by epriestley on Apr 5 2017, 6:05 PM.
Tags
None
Referenced Files
F14095063: D17626.diff
Mon, Nov 25, 7:34 PM
Unknown Object (File)
Fri, Nov 22, 6:19 AM
Unknown Object (File)
Sun, Nov 17, 10:43 PM
Unknown Object (File)
Wed, Nov 13, 6:59 PM
Unknown Object (File)
Sun, Nov 10, 5:48 AM
Unknown Object (File)
Wed, Nov 6, 5:48 AM
Unknown Object (File)
Sun, Nov 3, 6:21 AM
Unknown Object (File)
Wed, Oct 30, 10:59 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12219: Some MP4 videos do not play in Chrome
Commits
rPd1a971e22156: Support "Range: bytes=123-" requests
Summary

Ref T12219. We currently only support Range requests like "bytes=123-456", but "bytes=123-", meaning "until end of file", is valid, and Chrome can send these requests.

I suspect this is the issue with T12219.

Test Plan

Used nc local.phacility.com 80 to pipe raw requests, saw both "bytes=123-456" and "bytes=123-" requests satisfied correctly.

Diff Detail

Repository
rP Phabricator
Branch
files16
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16322
Build 21701: Run Core Tests
Build 21700: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 5 2017, 6:05 PM
Harbormaster completed remote builds in B16322: Diff 42392.Apr 5 2017, 6:06 PM
chad accepted this revision.Apr 5 2017, 6:24 PM
This revision is now accepted and ready to land.Apr 5 2017, 6:24 PM
Closed by commit rPd1a971e22156: Support "Range: bytes=123-" requests (authored by epriestley, committed by epriestley). · Explain WhyApr 5 2017, 6:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
aphront/
response/
5 lines
applications/
files/
controller/
13 lines
format/
__tests__/
8 lines

Diff 42392

View Options

src/aphront/response/AphrontFileResponse.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileDataController.php

Loading...
View Options

src/applications/files/format/__tests__/PhabricatorFileStorageFormatTestCase.php

Loading...
Phabricator · Built by Phacility