Page MenuHomePhabricator

Correct an issue where the wrong "Content-Length" was set for partial content responses
ClosedPublic

Authored by epriestley on Apr 5 2017, 1:53 PM.
Tags
None
Referenced Files
F15526529: D17624.id42388.diff
Mon, Apr 21, 9:17 PM
F15525773: D17624.id42391.diff
Mon, Apr 21, 4:46 PM
F15525652: D17624.diff
Mon, Apr 21, 3:53 PM
F15519530: D17624.id.diff
Sat, Apr 19, 11:36 PM
F15516273: D17624.diff
Fri, Apr 18, 5:38 PM
F15505072: D17624.id.diff
Mon, Apr 14, 11:40 PM
F15477080: D17624.id42391.diff
Mon, Apr 7, 12:11 PM
F15462452: D17624.diff
Tue, Apr 1, 3:11 PM
Subscribers
None

Details

Summary

Ref T8266. Although we compute this correctly above, we ignored it when actually setting the header. Use the computed value to set the "Content-Length" header. This is consistent with the spec/documentation.

Test Plan

Before, some audio (like rain.mp3) was pretty spotty about loading in Safari. It now loads consistently for me locally.

Diff Detail

Repository
rP Phabricator
Branch
files14
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16318
Build 21695: Run Core Tests
Build 21694: arc lint + arc unit