Page MenuHomePhabricator

Correct an issue where the wrong "Content-Length" was set for partial content responses
ClosedPublic

Authored by epriestley on Apr 5 2017, 1:53 PM.
Tags
None
Referenced Files
F14017797: D17624.id42391.diff
Mon, Nov 4, 11:01 PM
F14009035: D17624.id42391.diff
Wed, Oct 30, 8:42 AM
F14005864: D17624.id42391.diff
Sun, Oct 27, 9:04 PM
F14005863: D17624.id42388.diff
Sun, Oct 27, 9:04 PM
F14005862: D17624.id.diff
Sun, Oct 27, 9:04 PM
F14003037: D17624.diff
Sat, Oct 26, 1:22 AM
F14001579: D17624.diff
Fri, Oct 25, 9:45 AM
F13999170: D17624.diff
Thu, Oct 24, 1:11 PM
Subscribers
None

Details

Summary

Ref T8266. Although we compute this correctly above, we ignored it when actually setting the header. Use the computed value to set the "Content-Length" header. This is consistent with the spec/documentation.

Test Plan

Before, some audio (like rain.mp3) was pretty spotty about loading in Safari. It now loads consistently for me locally.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable