Page MenuHomePhabricator

Allow "arc upload" to work correctly if it can not hash content
ClosedPublic

Authored by epriestley on Apr 4 2017, 10:48 PM.
Tags
None
Referenced Files
F19055972: D17621.id.diff
Fri, Nov 28, 6:47 PM
F19050695: D17621.diff
Thu, Nov 27, 9:03 PM
F18833537: D17621.id42384.diff
Oct 26 2025, 4:18 AM
F18821268: D17621.diff
Oct 22 2025, 9:19 PM
F18791407: D17621.id.diff
Oct 16 2025, 12:38 PM
F18789115: D17621.id42373.diff
Oct 15 2025, 8:05 AM
F18762440: D17621.id.diff
Oct 6 2025, 7:02 PM
F18758185: D17621.diff
Oct 5 2025, 9:00 PM
Subscribers
None

Details

Summary

Ref T12464. This is similar to D17619 and prepares us to move to SHA256 in the client.

Note that it's fine if arc and Phabricator disagree about hashing algorithms. We don't really trust the client anyway, so if things are mismatched clients will just end up transferring a bit more data instead of getting to cheat when Phabricator already has copies of data.

Test Plan

Ran arc upload, got a clean upload.

Diff Detail

Repository
rARC Arcanist
Branch
files11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16300
Build 21673: Run Core Tests
Build 21672: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Apr 4 2017, 10:57 PM
This revision was automatically updated to reflect the committed changes.