Page MenuHomePhabricator
Differential D17621

Allow "arc upload" to work correctly if it can not hash content
ClosedPublic
Actions

Authored by epriestley on Apr 4 2017, 10:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 9, 8:08 PM
Unknown Object (File)
Tue, Apr 9, 7:15 PM
Unknown Object (File)
Tue, Apr 9, 6:37 PM
Unknown Object (File)
Tue, Apr 9, 6:37 PM
Unknown Object (File)
Tue, Apr 9, 6:35 PM
Unknown Object (File)
Tue, Apr 9, 6:33 PM
Unknown Object (File)
Tue, Apr 9, 5:34 PM
Unknown Object (File)
Fri, Apr 5, 7:04 AM
View All 81 Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12464: Move away from SHA1 in Files
Commits
rARCc4e84550fcd3: Allow "arc upload" to work correctly if it can not hash content
Summary

Ref T12464. This is similar to D17619 and prepares us to move to SHA256 in the client.

Note that it's fine if arc and Phabricator disagree about hashing algorithms. We don't really trust the client anyway, so if things are mismatched clients will just end up transferring a bit more data instead of getting to cheat when Phabricator already has copies of data.

Test Plan

Ran arc upload, got a clean upload.

Diff Detail

Repository
rARC Arcanist
Branch
files11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16300
Build 21673: Run Core Tests
Build 21672: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 4 2017, 10:48 PM
Harbormaster completed remote builds in B16300: Diff 42373.Apr 4 2017, 10:49 PM
chad accepted this revision.Apr 4 2017, 10:57 PM
This revision is now accepted and ready to land.Apr 4 2017, 10:57 PM
Closed by commit rARCc4e84550fcd3: Allow "arc upload" to work correctly if it can not hash content (authored by epriestley, committed by epriestley). · Explain WhyApr 4 2017, 11:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
upload/
21 lines

Diff 42373

View Options

src/upload/ArcanistFileDataRef.php

Loading...
Phabricator · Built by Phacility