Provide a missing feed transaction string for space creation
ClosedPublic
Actions

Authored by epriestley on Apr 4 2017, 12:56 PM.

Tags

None

Referenced Files

	F14082592: D17609.diff
	Sat, Nov 23, 12:28 AM

	F14082564: D17609.diff
	Sat, Nov 23, 12:24 AM

	Unknown Object (File)
	Wed, Nov 20, 8:09 PM

	Unknown Object (File)
	Mon, Nov 18, 10:23 PM

	Unknown Object (File)
	Wed, Nov 13, 10:14 PM

	Unknown Object (File)
	Wed, Nov 13, 12:21 AM

	Unknown Object (File)
	Oct 18 2024, 10:46 PM

	Unknown Object (File)
	Oct 15 2024, 8:59 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12502: Creating a task in the non-default space causes exception in feed renderer

Commits

rP5e447112184e: Provide a missing feed transaction string for space creation

Summary

Fixes T12502. This transaction probably should not be getting picked for feed rendering, but it currently does get selected in some cases.

This should probably be revisited eventually (e.g., when Maniphest moves to ModularTransactions) but just fix the brokenness for now.

Test Plan

Created a task in a space.
Viewed feed.
Saw the story render with readable text.

Screen Shot 2017-04-04 at 5.54.57 AM.png (163×630 px, 29 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 4 2017, 12:56 PM

Harbormaster completed remote builds in B16280: Diff 42353.Apr 4 2017, 12:57 PM

chad accepted this revision.Apr 4 2017, 5:03 PM

This revision is now accepted and ready to land.Apr 4 2017, 5:03 PM

Closed by commit rP5e447112184e: Provide a missing feed transaction string for space creation (authored by epriestley, committed by epriestley). · Explain WhyApr 4 2017, 5:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

storage/

PhabricatorApplicationTransaction.php

20 lines

Diff 42361

View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Provide a missing feed transaction string for space creationClosedPublicActions