Page MenuHomePhabricator

Custom fields: Render 'required' for tokenizer fields
ClosedPublic

Authored by fooishbar on Apr 1 2017, 3:57 PM.
Tags
None
Referenced Files
F17947209: D17592.diff
Thu, Jul 31, 3:48 PM
F17878720: D17592.diff
Mon, Jul 28, 8:28 PM
F17643711: D17592.id42325.diff
Fri, Jul 11, 9:52 PM
Unknown Object (File)
Jul 2 2025, 9:44 PM
Unknown Object (File)
Jun 28 2025, 11:45 PM
Unknown Object (File)
May 30 2025, 12:02 PM
Unknown Object (File)
May 29 2025, 9:13 AM
Unknown Object (File)
May 29 2025, 4:15 AM
Subscribers

Details

Summary

When building a tokenizer-based edit control for a custom field (e.g. a datasource type), preserve a field validation error whilst building edit controls.

Test Plan
  • Create custom datasource field, set it to required
  • Observe that 'Required' does not appear next to control
  • Apply patch
  • Observe 'Required' appears next to control

Diff Detail

Repository
rP Phabricator
Branch
upstream (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16245
Build 21583: Run Core Tests
Build 21582: arc lint + arc unit