Page MenuHomePhabricator

Custom fields: Render 'required' for tokenizer fields
ClosedPublic

Authored by fooishbar on Apr 1 2017, 3:57 PM.
Tags
None
Referenced Files
F14445099: D17592.id42325.diff
Thu, Dec 26, 11:53 AM
F14445096: D17592.id.diff
Thu, Dec 26, 11:52 AM
Unknown Object (File)
Wed, Dec 18, 7:53 AM
Unknown Object (File)
Wed, Dec 11, 8:24 AM
Unknown Object (File)
Mon, Dec 9, 10:40 PM
Unknown Object (File)
Sat, Dec 7, 4:53 PM
Unknown Object (File)
Sat, Dec 7, 1:57 AM
Unknown Object (File)
Tue, Dec 3, 5:08 PM
Subscribers

Details

Summary

When building a tokenizer-based edit control for a custom field (e.g. a datasource type), preserve a field validation error whilst building edit controls.

Test Plan
  • Create custom datasource field, set it to required
  • Observe that 'Required' does not appear next to control
  • Apply patch
  • Observe 'Required' appears next to control

Diff Detail

Repository
rP Phabricator
Branch
upstream (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16245
Build 21583: Run Core Tests
Build 21582: arc lint + arc unit