Page MenuHomePhabricator

Custom fields: Render 'required' for tokenizer fields
ClosedPublic

Authored by fooishbar on Apr 1 2017, 3:57 PM.
Tags
None
Referenced Files
F19689173: D17592.id42325.diff
Mon, Feb 9, 8:45 PM
F19672093: D17592.id42325.diff
Sun, Feb 8, 2:26 AM
F19154111: D17592.id42319.diff
Dec 11 2025, 1:30 PM
F19153904: D17592.id42319.diff
Dec 11 2025, 12:40 PM
F19152604: D17592.diff
Dec 11 2025, 3:59 AM
F19152572: D17592.diff
Dec 11 2025, 3:42 AM
F19056652: D17592.id42325.diff
Nov 28 2025, 8:15 PM
F19055897: D17592.id42319.diff
Nov 28 2025, 6:34 PM
Subscribers

Details

Summary

When building a tokenizer-based edit control for a custom field (e.g. a datasource type), preserve a field validation error whilst building edit controls.

Test Plan
  • Create custom datasource field, set it to required
  • Observe that 'Required' does not appear next to control
  • Apply patch
  • Observe 'Required' appears next to control

Diff Detail

Repository
rP Phabricator
Branch
upstream (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16245
Build 21583: Run Core Tests
Build 21582: arc lint + arc unit