Page MenuHomePhabricator

Don't summon the emoji autocompleter for ":3"
ClosedPublic

Authored by epriestley on Mar 28 2017, 10:40 PM.
Tags
None
Referenced Files
F14032193: D17577.diff
Sat, Nov 9, 1:16 PM
F14004318: D17577.diff
Sat, Oct 26, 6:28 PM
F13965294: D17577.id.diff
Wed, Oct 16, 1:07 AM
Unknown Object (File)
Sep 30 2024, 5:50 PM
Unknown Object (File)
Sep 24 2024, 1:08 PM
Unknown Object (File)
Sep 9 2024, 3:24 PM
Unknown Object (File)
Sep 5 2024, 11:35 PM
Unknown Object (File)
Aug 30 2024, 5:29 PM
Subscribers
None

Details

Summary

Fixes T12460. Also ":)", ":(", ":/", and oldschool ":-)" variants.

Not included are variants with actual letters (:D, :O, :P) and obscure variants (:^), :*)).

Test Plan

Typed :3 (no emoji summoned). Typed :dog3 (emoji summoned). Typed @3 (user autocomplete summoned).

Diff Detail

Repository
rP Phabricator
Branch
emoji1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16212
Build 21527: Run Core Tests
Build 21526: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mar 28 2017, 10:47 PM
This revision was automatically updated to reflect the committed changes.