Tags

None

Referenced Files

	F15519234: D17563.id42255.diff
	Sat, Apr 19, 9:04 PM

	F15486598: D17563.id42248.diff
	Thu, Apr 10, 8:18 AM

	F15441654: D17563.id42250.diff
	Wed, Mar 26, 7:09 PM

	F15427747: D17563.id42247.diff
	Mar 23 2025, 3:54 PM

	F15418717: D17563.diff
	Mar 21 2025, 1:01 AM

	F15398984: D17563.id42250.diff
	Mar 17 2025, 2:12 AM

	F15389501: D17563.id42249.diff
	Mar 15 2025, 5:21 AM

	F15388627: D17563.id42248.diff
	Mar 15 2025, 4:08 AM

View All Files

Subscribers

Korvin

Tokens

"Love" token, awarded by 20after4.

Details

Reviewers

epriestley

Commits

rP76404c5fdb6a: Cleaner fullscreen / preview states for Remarkup bar

Summary

General CSS and usability touchup of the Remarkup bar states for fullscreen and preview. Larger fonts, more spacing, some hint of the underlying page. Disable buttons that can't be used in preview mode.

Test Plan

Formal test coming with mobile, browsers. This is a kick the tires upload.

Screen Shot 2017-03-26 at 5.32.05 PM.png (1×2 px, 988 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Mar 27 2017, 12:32 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 27 2017, 12:32 AM

Harbormaster completed remote builds in B16172: Diff 42247.Mar 27 2017, 12:32 AM

chad edited the test plan for this revision. (Show Details)Mar 27 2017, 12:33 AM

Harbormaster completed remote builds in B16172: Diff 42247.Mar 27 2017, 12:33 AM

mobile ui, reorder css

Harbormaster completed remote builds in B16173: Diff 42248.Mar 27 2017, 5:04 AM

Harbormaster completed remote builds in B16173: Diff 42248.

useless animations

Harbormaster completed remote builds in B16174: Diff 42249.Mar 27 2017, 5:10 AM

Harbormaster completed remote builds in B16174: Diff 42249.

more organization
minor padding

Harbormaster completed remote builds in B16175: Diff 42250.Mar 27 2017, 5:35 AM

20after4 awarded a token.Mar 27 2017, 10:14 AM

If you fullscreen, then click "Upload File", do the masks get screwed up and/or stuck?

This revision is now accepted and ready to land.Mar 27 2017, 3:14 PM

seems like an existing condition that's no worse

there are a few other full screen bugs, like disabling SOE in Conpherence that I want to fix too. I'll look into the upload bug.

Closed by commit rP76404c5fdb6a: Cleaner fullscreen / preview states for Remarkup bar (authored by chad, committed by chad). · Explain WhyMar 27 2017, 4:19 PM

This revision was automatically updated to reflect the committed changes.

Cleaner fullscreen / preview states for Remarkup bar
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 42255

resources/celerity/map.php

src/view/form/control/PhabricatorRemarkupControl.php

webroot/rsrc/css/core/remarkup.css

webroot/rsrc/css/phui/phui-comment-form.css

webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js

Cleaner fullscreen / preview states for Remarkup barClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42255

resources/celerity/map.php

src/view/form/control/PhabricatorRemarkupControl.php

webroot/rsrc/css/core/remarkup.css

webroot/rsrc/css/phui/phui-comment-form.css

webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js

Cleaner fullscreen / preview states for Remarkup bar
ClosedPublic
Actions

Revision Contents
Changeset List