Page MenuHomePhabricator
Differential D17563

Cleaner fullscreen / preview states for Remarkup bar
ClosedPublic
Actions

Authored by chad on Mar 27 2017, 12:32 AM.
Tags
None
Referenced Files
F14082438: D17563.diff
Fri, Nov 22, 11:54 PM
F14081476: D17563.diff
Fri, Nov 22, 8:08 PM
Unknown Object (File)
Mon, Nov 18, 7:19 PM
Unknown Object (File)
Fri, Nov 15, 1:47 AM
Unknown Object (File)
Sun, Nov 10, 4:41 PM
Unknown Object (File)
Thu, Nov 7, 2:29 PM
Unknown Object (File)
Thu, Oct 31, 12:24 AM
Unknown Object (File)
Tue, Oct 29, 11:35 PM
View All Files
Subscribers
Korvin
Tokens
"Love" token, awarded by 20after4.

Details

Reviewers
epriestley
Commits
rP76404c5fdb6a: Cleaner fullscreen / preview states for Remarkup bar
Summary

General CSS and usability touchup of the Remarkup bar states for fullscreen and preview. Larger fonts, more spacing, some hint of the underlying page. Disable buttons that can't be used in preview mode.

Test Plan

Formal test coming with mobile, browsers. This is a kick the tires upload.

Screen Shot 2017-03-26 at 5.32.05 PM.png (1×2 px, 988 KB)

Diff Detail

Repository
rP Phabricator
Branch
fullscreen-editor (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16174
Build 21467: Run Core Tests
Build 21466: arc lint + arc unit

Event Timeline

chad created this revision.Mar 27 2017, 12:32 AM
Herald added a subscriber: Korvin. · View Herald TranscriptMar 27 2017, 12:32 AM
Harbormaster completed remote builds in B16172: Diff 42247.Mar 27 2017, 12:32 AM
chad edited the test plan for this revision. (Show Details)Mar 27 2017, 12:33 AM
Harbormaster completed remote builds in B16172: Diff 42247.Mar 27 2017, 12:33 AM
chad updated this revision to Diff 42248.Mar 27 2017, 5:04 AM
  • mobile ui, reorder css
Harbormaster completed remote builds in B16173: Diff 42248.Mar 27 2017, 5:04 AM
Harbormaster completed remote builds in B16173: Diff 42248.
chad updated this revision to Diff 42249.Mar 27 2017, 5:10 AM
  • useless animations
Harbormaster completed remote builds in B16174: Diff 42249.Mar 27 2017, 5:10 AM
Harbormaster completed remote builds in B16174: Diff 42249.
chad updated this revision to Diff 42250.Mar 27 2017, 5:34 AM
  • more organization
  • minor padding
Harbormaster completed remote builds in B16175: Diff 42250.Mar 27 2017, 5:35 AM
20after4 awarded a token.Mar 27 2017, 10:14 AM
epriestley accepted this revision.Mar 27 2017, 3:14 PM

If you fullscreen, then click "Upload File", do the masks get screwed up and/or stuck?

This revision is now accepted and ready to land.Mar 27 2017, 3:14 PM
chad added a comment.Mar 27 2017, 3:45 PM

seems like an existing condition that's no worse

chad added a comment.Mar 27 2017, 3:46 PM

there are a few other full screen bugs, like disabling SOE in Conpherence that I want to fix too. I'll look into the upload bug.

Closed by commit rP76404c5fdb6a: Cleaner fullscreen / preview states for Remarkup bar (authored by chad, committed by chad). · Explain WhyMar 27 2017, 4:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
33 lines
src/
view/
form/
control/
9 lines
webroot/
rsrc/
css/
core/
198 lines
js/
core/
5 lines

Diff 42249

View Options

resources/celerity/map.php

Loading...
View Options

src/view/form/control/PhabricatorRemarkupControl.php

Loading...
View Options

webroot/rsrc/css/core/remarkup.css

Loading...
View Options

webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js

Loading...
Phabricator · Built by Phacility