Page MenuHomePhabricator
Differential D17544

Restrict Differential buckets to just ApplicationSearch views
ClosedPublic
Actions

Authored by chad on Mar 23 2017, 7:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 29, 9:36 PM
Unknown Object (File)
Fri, Jan 24, 4:48 PM
Unknown Object (File)
Tue, Jan 21, 3:33 PM
Unknown Object (File)
Sun, Jan 19, 1:50 PM
Unknown Object (File)
Fri, Jan 17, 11:19 PM
Unknown Object (File)
Sun, Jan 12, 1:51 AM
Unknown Object (File)
Wed, Jan 8, 9:44 PM
Unknown Object (File)
Jan 3 2025, 10:11 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T9363: improve handling of panels that do not always return results
Commits
rPffab52f17e19: Restrict Differential buckets to just ApplicationSearch views
Summary

Ref T9363, If we're in a dashboard panel, only show buckets with data, or a fallback if nothing exists.

Test Plan

Test 'active revisions' panel in a dashboard and in Differential.

Diff Detail

Repository
rP Phabricator
Branch
differential-buckets (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16114
Build 21383: Run Core Tests
Build 21382: arc lint + arc unit

Event Timeline

chad created this revision.Mar 23 2017, 7:06 PM
Herald added a subscriber: Korvin. · View Herald TranscriptMar 23 2017, 7:06 PM
Harbormaster completed remote builds in B16114: Diff 42200.Mar 23 2017, 7:07 PM
epriestley accepted this revision.Mar 23 2017, 7:09 PM
This revision is now accepted and ready to land.Mar 23 2017, 7:09 PM
Closed by commit rPffab52f17e19: Restrict Differential buckets to just ApplicationSearch views (authored by chad, committed by chad). · Explain WhyMar 23 2017, 7:09 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Mar 23 2017, 7:13 PM

hah. doesn't solve the default homepage issue. only if you make a dashboard.

epriestley added a comment.Mar 23 2017, 7:29 PM

You can probably setIsPanelContext(true) or something on the hard-coded home pagey thing, maaaaybe.

epriestley added a comment.Mar 23 2017, 7:30 PM

or I made that up

iiam

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
query/
17 lines

Diff 42200

View Options

src/applications/differential/query/DifferentialRevisionSearchEngine.php

Loading...
Phabricator · Built by Phacility