Restrict Differential buckets to just ApplicationSearch views
ClosedPublic
Actions

Authored by chad on Mar 23 2017, 7:06 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T9363: improve handling of panels that do not always return results

Commits

rPffab52f17e19: Restrict Differential buckets to just ApplicationSearch views

Summary

Ref T9363, If we're in a dashboard panel, only show buckets with data, or a fallback if nothing exists.

Test Plan

Test 'active revisions' panel in a dashboard and in Differential.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Mar 23 2017, 7:06 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 23 2017, 7:06 PM

Harbormaster completed remote builds in B16114: Diff 42200.Mar 23 2017, 7:07 PM

epriestley accepted this revision.Mar 23 2017, 7:09 PM

This revision is now accepted and ready to land.Mar 23 2017, 7:09 PM

Closed by commit rPffab52f17e19: Restrict Differential buckets to just ApplicationSearch views (authored by chad, committed by chad). · Explain WhyMar 23 2017, 7:09 PM

This revision was automatically updated to reflect the committed changes.

hah. doesn't solve the default homepage issue. only if you make a dashboard.

You can probably setIsPanelContext(true) or something on the hard-coded home pagey thing, maaaaybe.

or I made that up

iiam

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

query/

DifferentialRevisionSearchEngine.php

17 lines

Diff 42201

View Options

src/applications/differential/query/DifferentialRevisionSearchEngine.php

Restrict Differential buckets to just ApplicationSearch viewsClosedPublicActions