Paths

Table of Contentst

Restrict Differential buckets to just ApplicationSearch views
ClosedPublic
Actions

Authored by chad on Mar 23 2017, 7:06 PM.

Tags

None

Referenced Files

	F15494753: D17544.id42200.diff
	Sun, Apr 13, 1:32 AM

	F15492906: D17544.id42201.diff
	Sat, Apr 12, 7:32 PM

	F15490491: D17544.id.diff
	Fri, Apr 11, 5:55 PM

	F15487041: D17544.diff
	Thu, Apr 10, 10:44 AM

	F15480439: D17544.diff
	Tue, Apr 8, 2:06 PM

	F15463148: D17544.id.diff
	Tue, Apr 1, 8:44 PM

	F15422219: D17544.id.diff
	Sat, Mar 22, 6:43 AM

	Unknown Object (File)
	Feb 16 2025, 12:24 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T9363: improve handling of panels that do not always return results

Commits

rPffab52f17e19: Restrict Differential buckets to just ApplicationSearch views

Summary

Ref T9363, If we're in a dashboard panel, only show buckets with data, or a fallback if nothing exists.

Test Plan

Test 'active revisions' panel in a dashboard and in Differential.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Mar 23 2017, 7:06 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 23 2017, 7:06 PM

Harbormaster completed remote builds in B16114: Diff 42200.Mar 23 2017, 7:07 PM

epriestley accepted this revision.Mar 23 2017, 7:09 PM

This revision is now accepted and ready to land.Mar 23 2017, 7:09 PM

Closed by commit rPffab52f17e19: Restrict Differential buckets to just ApplicationSearch views (authored by chad, committed by chad). · Explain WhyMar 23 2017, 7:09 PM

This revision was automatically updated to reflect the committed changes.

hah. doesn't solve the default homepage issue. only if you make a dashboard.

You can probably setIsPanelContext(true) or something on the hard-coded home pagey thing, maaaaybe.

or I made that up

iiam

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

query/

DifferentialRevisionSearchEngine.php

17 lines

Diff 42201

View Options

src/applications/differential/query/DifferentialRevisionSearchEngine.php

Restrict Differential buckets to just ApplicationSearch viewsClosedPublicActions