Don't require mentioned objects to have all required fields when editing comments
ClosedPublic
Actions

Authored by epriestley on Mar 22 2017, 4:55 PM.

Details

Reviewers

chad

Maniphest Tasks

T12439: Maniphest comment editing fails with required custom field and edge

Commits

rP9c998e988b1d: Don't require mentioned objects to have all required fields when editing…

Summary

Fixes T12439. This pathway was just missing a setContinueOnMissingFields(...) to skip enforcement of required fields.

Test Plan

Added a required custom field.
Mentioned any task without a field value in a comment.
Edited that comment.
Saved changes.
Before fix: fatal in log.
After fix: clean edit.

Diff Detail

Repository

rP Phabricator

Branch

edit1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16091
Build 21351: Run Core Tests
Build 21350: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 22 2017, 4:55 PM

chad accepted this revision.Mar 22 2017, 4:55 PM

This revision is now accepted and ready to land.Mar 22 2017, 4:55 PM

Harbormaster completed remote builds in B16091: Diff 42176.Mar 22 2017, 4:56 PM

Closed by commit rP9c998e988b1d: Don't require mentioned objects to have all required fields when editing… (authored by epriestley, committed by epriestley). · Explain WhyMar 22 2017, 4:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editor/

PhabricatorApplicationTransactionCommentEditor.php

1 line

Diff 42176

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php

Don't require mentioned objects to have all required fields when editing commentsClosedPublicActions