Paths

Table of Contentst

Differential D17536

Don't require mentioned objects to have all required fields when editing comments
ClosedPublic
Actions

Authored by epriestley on Mar 22 2017, 4:55 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 3, 5:01 AM

	Unknown Object (File)
	Thu, Apr 25, 12:44 AM

	Unknown Object (File)
	Thu, Apr 11, 8:34 AM

	Unknown Object (File)
	Mon, Apr 8, 3:11 AM

	Unknown Object (File)
	Apr 2 2024, 5:05 AM

	Unknown Object (File)
	Mar 20 2024, 10:31 PM

	Unknown Object (File)
	Feb 11 2024, 7:23 PM

	Unknown Object (File)
	Feb 11 2024, 7:22 PM

View All 84 Files

Subscribers

None

Details

Reviewers

Maniphest Tasks

T12439: Maniphest comment editing fails with required custom field and edge

Commits

rP9c998e988b1d: Don't require mentioned objects to have all required fields when editing…

Summary

Fixes T12439. This pathway was just missing a setContinueOnMissingFields(...) to skip enforcement of required fields.

Test Plan

Added a required custom field.
Mentioned any task without a field value in a comment.
Edited that comment.
Saved changes.
Before fix: fatal in log.
After fix: clean edit.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 22 2017, 4:55 PM

chad accepted this revision.Mar 22 2017, 4:55 PM

This revision is now accepted and ready to land.Mar 22 2017, 4:55 PM

Harbormaster completed remote builds in B16091: Diff 42176.Mar 22 2017, 4:56 PM

Closed by commit rP9c998e988b1d: Don't require mentioned objects to have all required fields when editing… (authored by epriestley, committed by epriestley). · Explain WhyMar 22 2017, 4:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editor/

PhabricatorApplicationTransactionCommentEditor.php

1 line

Diff 42178

src/applications/transactions/editor/PhabricatorApplicationTransactionCommentEditor.php

Loading...