Page MenuHomePhabricator

Apply reviewer changes from Herald via ModularTransactions
ClosedPublic

Authored by epriestley on Mar 20 2017, 3:47 PM.
Tags
None
Referenced Files
F15284340: D17511.diff
Tue, Mar 4, 9:35 AM
Unknown Object (File)
Wed, Feb 19, 9:03 PM
Unknown Object (File)
Tue, Feb 18, 2:22 PM
Unknown Object (File)
Sun, Feb 9, 3:29 AM
Unknown Object (File)
Sun, Feb 9, 3:29 AM
Unknown Object (File)
Sun, Feb 9, 3:29 AM
Unknown Object (File)
Jan 31 2025, 6:24 AM
Unknown Object (File)
Jan 28 2025, 2:18 AM
Subscribers
None

Details

Summary

Ref T10967. This converts the reviewer update action in Herald from an older edge write to a newer ModularTransactions write.

The major value from this is that we get a double-write to the new reviewers table.

Test Plan
  • Wrote a Herald rule to add a reviewer and a blocking reviewer.
  • Saw them added properly to a revision with: no reviewers; both as blocking; A as blocking, B as nonblocking; A as nonblocking, B as blocking.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 20 2017, 4:05 PM
This revision was automatically updated to reflect the committed changes.