Ref T10967. This converts the reviewer update action in Herald from an older edge write to a newer ModularTransactions write.
The major value from this is that we get a double-write to the new reviewers table.
Details
Details
- Wrote a Herald rule to add a reviewer and a blocking reviewer.
- Saw them added properly to a revision with: no reviewers; both as blocking; A as blocking, B as nonblocking; A as nonblocking, B as blocking.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- rev1
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 16035 Build 21261: Run Core Tests Build 21260: arc lint + arc unit