Page MenuHomePhabricator

Rename "needReviewerStatus()" into "needReviewers()"
ClosedPublic

Authored by epriestley on Mar 20 2017, 9:46 PM.
Tags
None
Referenced Files
F15473285: D17519.id42143.diff
Sat, Apr 5, 8:53 PM
F15468828: D17519.diff
Fri, Apr 4, 6:18 AM
F15437441: D17519.id.diff
Tue, Mar 25, 7:25 PM
F15433549: D17519.diff
Mon, Mar 24, 11:44 PM
F15409744: D17519.diff
Wed, Mar 19, 5:03 AM
F15408253: D17519.id42143.diff
Tue, Mar 18, 9:55 PM
F15379228: D17519.diff
Thu, Mar 13, 7:33 PM
Unknown Object (File)
Feb 16 2025, 1:51 PM
Subscribers
None

Details

Summary

Ref T10967. The old name was because we had a getReviewers() tied to needRelationships(), rename this method to use a simpler and more clear name.

Test Plan

grep, browsed around.

Diff Detail

Repository
rP Phabricator
Branch
rev8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16045
Build 21280: Run Core Tests
Build 21279: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mar 20 2017, 11:44 PM
This revision was automatically updated to reflect the committed changes.