Page MenuHomePhabricator

Rename "needReviewerStatus()" into "needReviewers()"
ClosedPublic

Authored by epriestley on Mar 20 2017, 9:46 PM.
Tags
None
Referenced Files
F18850534: D17519.id.diff
Thu, Oct 30, 5:38 PM
F18846872: D17519.diff
Wed, Oct 29, 9:37 PM
F18809753: D17519.id42143.diff
Sun, Oct 19, 4:35 PM
F18736887: D17519.id42130.diff
Wed, Oct 1, 8:09 AM
F18733516: D17519.id.diff
Sep 30 2025, 10:36 PM
F18678708: D17519.diff
Sep 25 2025, 11:11 PM
F18645063: D17519.diff
Sep 19 2025, 6:55 AM
F18400542: D17519.id.diff
Aug 29 2025, 6:23 PM
Subscribers
None

Details

Summary

Ref T10967. The old name was because we had a getReviewers() tied to needRelationships(), rename this method to use a simpler and more clear name.

Test Plan

grep, browsed around.

Diff Detail

Repository
rP Phabricator
Branch
rev8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16045
Build 21280: Run Core Tests
Build 21279: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mar 20 2017, 11:44 PM
This revision was automatically updated to reflect the committed changes.