Page MenuHomePhabricator

Rename "needReviewerStatus()" into "needReviewers()"
ClosedPublic

Authored by epriestley on Mar 20 2017, 9:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 29, 5:17 PM
Unknown Object (File)
Tue, Dec 24, 2:32 AM
Unknown Object (File)
Dec 8 2024, 8:59 PM
Unknown Object (File)
Dec 8 2024, 9:19 AM
Unknown Object (File)
Dec 6 2024, 3:49 PM
Unknown Object (File)
Dec 5 2024, 11:21 AM
Unknown Object (File)
Dec 5 2024, 7:57 AM
Unknown Object (File)
Dec 3 2024, 2:16 PM
Subscribers
None

Details

Summary

Ref T10967. The old name was because we had a getReviewers() tied to needRelationships(), rename this method to use a simpler and more clear name.

Test Plan

grep, browsed around.

Diff Detail

Repository
rP Phabricator
Branch
rev8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16045
Build 21280: Run Core Tests
Build 21279: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mar 20 2017, 11:44 PM
This revision was automatically updated to reflect the committed changes.