Page MenuHomePhabricator

Rename "needReviewerStatus()" into "needReviewers()"
ClosedPublic

Authored by epriestley on Mar 20 2017, 9:46 PM.
Tags
None
Referenced Files
F19888805: D17519.diff
Tue, Mar 24, 4:54 AM
F19888525: D17519.diff
Tue, Mar 24, 2:10 AM
F19819046: D17519.id42130.diff
Fri, Mar 6, 2:13 AM
F19819040: D17519.id42130.diff
Fri, Mar 6, 2:12 AM
F19669247: D17519.diff
Feb 7 2026, 8:31 PM
F19538273: D17519.id42130.diff
Jan 21 2026, 3:14 PM
F19504556: D17519.diff
Jan 9 2026, 5:22 AM
F19503417: D17519.id42143.diff
Jan 8 2026, 11:39 PM
Subscribers
None

Details

Summary

Ref T10967. The old name was because we had a getReviewers() tied to needRelationships(), rename this method to use a simpler and more clear name.

Test Plan

grep, browsed around.

Diff Detail

Repository
rP Phabricator
Branch
rev8
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16045
Build 21280: Run Core Tests
Build 21279: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mar 20 2017, 11:44 PM
This revision was automatically updated to reflect the committed changes.