Differential D17512

Apply Owners reviewers using ModularTransactions
ClosedPublic
Actions

Authored by epriestley on Mar 20 2017, 4:16 PM.

Details

Reviewers

chad

Maniphest Tasks

T10967: Move Differential reviewers back to a dedicated database storage table

Commits

rPa9cbbf3e5e15: Apply Owners reviewers using ModularTransactions

Summary

Ref T10967. See that task for some discussion. This lets us do double writes on this pathway.

Test Plan

Set an Owners package to auto-review. Created revisions which triggered it: one with no reviewers (autoreview added); one with the package as a blocking reviewer explicitly (no automatic stuff happened, as expected).

Diff Detail

Repository

rP Phabricator

Branch

rev2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16036
Build 21263: Run Core Tests
Build 21262: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 20 2017, 4:16 PM

Harbormaster completed remote builds in B16036: Diff 42121.Mar 20 2017, 4:17 PM

chad accepted this revision.Mar 20 2017, 4:39 PM

This revision is now accepted and ready to land.Mar 20 2017, 4:39 PM

Closed by commit rPa9cbbf3e5e15: Apply Owners reviewers using ModularTransactions (authored by epriestley, committed by epriestley). · Explain WhyMar 20 2017, 11:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

17 lines

Diff 42121

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Apply Owners reviewers using ModularTransactionsClosedPublicActions