Page MenuHomePhabricator

Apply Owners reviewers using ModularTransactions
ClosedPublic

Authored by epriestley on Mar 20 2017, 4:16 PM.
Tags
None
Referenced Files
F19510305: D17512.id42137.diff
Sun, Jan 11, 7:13 AM
F19510304: D17512.id42121.diff
Sun, Jan 11, 7:13 AM
F19505609: D17512.diff
Fri, Jan 9, 1:00 PM
F19505009: D17512.diff
Fri, Jan 9, 8:30 AM
F19502926: D17512.diff
Thu, Jan 8, 8:45 PM
F19490874: D17512.diff
Thu, Jan 8, 7:03 AM
F19472305: D17512.diff
Wed, Jan 7, 3:45 AM
F19265411: D17512.id.diff
Mon, Dec 22, 7:24 PM
Subscribers
None

Details

Summary

Ref T10967. See that task for some discussion. This lets us do double writes on this pathway.

Test Plan

Set an Owners package to auto-review. Created revisions which triggered it: one with no reviewers (autoreview added); one with the package as a blocking reviewer explicitly (no automatic stuff happened, as expected).

Diff Detail

Repository
rP Phabricator
Branch
rev2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16036
Build 21263: Run Core Tests
Build 21262: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mar 20 2017, 4:39 PM
This revision was automatically updated to reflect the committed changes.