Page MenuHomePhabricator

Apply Owners reviewers using ModularTransactions
ClosedPublic

Authored by epriestley on Mar 20 2017, 4:16 PM.
Tags
None
Referenced Files
F15542804: D17512.id.diff
Fri, Apr 25, 7:00 PM
F15538168: D17512.diff
Thu, Apr 24, 5:45 PM
F15526820: D17512.diff
Mon, Apr 21, 11:44 PM
F15492950: D17512.id.diff
Sat, Apr 12, 8:02 PM
F15489821: D17512.diff
Fri, Apr 11, 12:34 PM
F15454314: D17512.id42121.diff
Sat, Mar 29, 5:52 PM
F15449557: D17512.id42137.diff
Fri, Mar 28, 10:55 AM
F15448659: D17512.id42137.diff
Fri, Mar 28, 6:08 AM
Subscribers
None

Details

Summary

Ref T10967. See that task for some discussion. This lets us do double writes on this pathway.

Test Plan

Set an Owners package to auto-review. Created revisions which triggered it: one with no reviewers (autoreview added); one with the package as a blocking reviewer explicitly (no automatic stuff happened, as expected).

Diff Detail

Repository
rP Phabricator
Branch
rev2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16036
Build 21263: Run Core Tests
Build 21262: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mar 20 2017, 4:39 PM
This revision was automatically updated to reflect the committed changes.