Page MenuHomePhabricator

Add ActionIcon to PHUIListItemView, use in Dashboards
ClosedPublic

Authored by chad on Mar 16 2017, 6:21 PM.
Tags
None
Referenced Files
F14476653: D17505.id42097.diff
Sat, Dec 28, 7:15 AM
Unknown Object (File)
Wed, Dec 18, 6:45 AM
Unknown Object (File)
Tue, Dec 10, 6:40 AM
Unknown Object (File)
Tue, Dec 10, 2:51 AM
Unknown Object (File)
Sat, Dec 7, 4:03 AM
Unknown Object (File)
Fri, Dec 6, 1:26 PM
Unknown Object (File)
Fri, Dec 6, 11:33 AM
Unknown Object (File)
Fri, Nov 29, 6:23 PM
Subscribers

Details

Summary

Extends PHUIListItemView to take an icon, link as an "Action Item" that displays on the right side of the menu link. Does not display on Favorites. This allows for adding edit, external, or other links (documentation?) to any menu item. Right now the secondary link is only visible when the item is selected. This feels right, but if we offer it in other ways, users may always want it visible. We could look at making it onhover.

Test Plan

Add a bunch of random global and personal dashboards to my menu. Add a menu to Favorites, see no link. Test mobile, link works.

pasted_file (718×664 px, 73 KB)

Diff Detail

Repository
rP Phabricator
Branch
dashboard-edit (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 16004
Build 21218: Run Core Tests
Build 21217: arc lint + arc unit

Event Timeline

  • test for dashboards named "MMMMMMMMMMMMMMMMMMMMMMMMM" by users named hector
This revision is now accepted and ready to land.Mar 16 2017, 6:30 PM
This revision was automatically updated to reflect the committed changes.