Add badges to TransactionCommentView
ClosedPublic
Actions

Authored by chad on Mar 7 2017, 10:20 PM.

Tags

None

Referenced Files

	F13183399: D17480.id.diff
	Fri, May 10, 8:45 AM

	F13182028: D17480.id42032.diff
	Thu, May 9, 6:27 PM

	Unknown Object (File)
	Tue, May 7, 5:56 AM

	Unknown Object (File)
	Mon, May 6, 8:06 AM

	Unknown Object (File)
	Fri, May 3, 10:16 AM

	Unknown Object (File)
	Thu, May 2, 12:50 PM

	Unknown Object (File)
	Sun, Apr 28, 4:20 PM

	Unknown Object (File)
	Thu, Apr 25, 3:44 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T10698: Comment previews should display user badges under the author's profile image.

Commits

rP614c8497bb4a: Add badges to TransactionCommentView

Summary

Fixes T10698. This shows badges under the comment preview if the application uses TransactionCommentView. I suspect not everything does, but will pick the fix up for free when modernized.

Test Plan

Test commenting on a task with and without a user that has a badge. See badge preview.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.Mar 7 2017, 10:20 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 7 2017, 10:20 PM

Harbormaster completed remote builds in B15937: Diff 42031.Mar 7 2017, 10:21 PM

epriestley accepted this revision.Mar 7 2017, 11:56 PM

This revision is now accepted and ready to land.Mar 7 2017, 11:56 PM

Closed by commit rP614c8497bb4a: Add badges to TransactionCommentView (authored by chad, committed by chad). · Explain WhyMar 7 2017, 11:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

view/

PhabricatorApplicationTransactionCommentView.php

47 lines

Diff 42032

View Options

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

Add badges to TransactionCommentViewClosedPublicActions