Page MenuHomePhabricator

Add badges to TransactionCommentView
ClosedPublic

Authored by chad on Mar 7 2017, 10:20 PM.
Tags
None
Referenced Files
F13192019: D17480.id42032.diff
Sun, May 12, 3:56 AM
F13191927: D17480.id.diff
Sun, May 12, 2:41 AM
F13190866: D17480.id42032.diff
Sat, May 11, 2:46 PM
F13183399: D17480.id.diff
Fri, May 10, 8:45 AM
F13182028: D17480.id42032.diff
Thu, May 9, 6:27 PM
Unknown Object (File)
Tue, May 7, 5:56 AM
Unknown Object (File)
Mon, May 6, 8:06 AM
Unknown Object (File)
Fri, May 3, 10:16 AM
Subscribers

Details

Summary

Fixes T10698. This shows badges under the comment preview if the application uses TransactionCommentView. I suspect not everything does, but will pick the fix up for free when modernized.

Test Plan

Test commenting on a task with and without a user that has a badge. See badge preview.

Diff Detail

Repository
rP Phabricator
Branch
preview-badges (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15937
Build 21109: Run Core Tests
Build 21108: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mar 7 2017, 11:56 PM
This revision was automatically updated to reflect the committed changes.