Page MenuHomePhabricator

Add badges to TransactionCommentView
ClosedPublic

Authored by chad on Mar 7 2017, 10:20 PM.
Tags
None
Referenced Files
F15525739: D17480.id42031.diff
Mon, Apr 21, 4:30 PM
F15524583: D17480.id42032.diff
Mon, Apr 21, 8:59 AM
F15522849: D17480.diff
Sun, Apr 20, 9:50 PM
F15520766: D17480.id.diff
Sun, Apr 20, 8:09 AM
F15518359: D17480.diff
Sat, Apr 19, 12:56 PM
F15420868: D17480.id42031.diff
Mar 21 2025, 6:25 PM
F15419926: D17480.id42032.diff
Mar 21 2025, 9:57 AM
F15419733: D17480.diff
Mar 21 2025, 8:28 AM
Subscribers

Details

Summary

Fixes T10698. This shows badges under the comment preview if the application uses TransactionCommentView. I suspect not everything does, but will pick the fix up for free when modernized.

Test Plan

Test commenting on a task with and without a user that has a badge. See badge preview.

Diff Detail

Repository
rP Phabricator
Branch
preview-badges (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15937
Build 21109: Run Core Tests
Build 21108: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mar 7 2017, 11:56 PM
This revision was automatically updated to reflect the committed changes.