Page MenuHomePhabricator

Add badges to TransactionCommentView
ClosedPublic

Authored by chad on Mar 7 2017, 10:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 5:37 PM
Unknown Object (File)
Mon, Dec 9, 4:37 AM
Unknown Object (File)
Tue, Dec 3, 12:26 PM
Unknown Object (File)
Sat, Nov 30, 12:41 AM
Unknown Object (File)
Nov 28 2024, 2:03 PM
Unknown Object (File)
Nov 27 2024, 9:08 AM
Unknown Object (File)
Nov 25 2024, 1:46 PM
Unknown Object (File)
Nov 21 2024, 12:26 AM
Subscribers

Details

Summary

Fixes T10698. This shows badges under the comment preview if the application uses TransactionCommentView. I suspect not everything does, but will pick the fix up for free when modernized.

Test Plan

Test commenting on a task with and without a user that has a badge. See badge preview.

Diff Detail

Repository
rP Phabricator
Branch
preview-badges (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15937
Build 21109: Run Core Tests
Build 21108: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mar 7 2017, 11:56 PM
This revision was automatically updated to reflect the committed changes.