Set a max-width on crumbs just in case
ClosedPublic
Actions

Authored by chad on Mar 6 2017, 6:37 PM.

Tags

None

Referenced Files

	F13216582: D17472.id.diff
	Sat, May 18, 1:22 AM

	F13200507: D17472.id42016.diff
	Tue, May 14, 12:55 AM

	F13190972: D17472.id42017.diff
	Sat, May 11, 3:54 PM

	F13187910: D17472.diff
	Sat, May 11, 4:50 AM

	F13174369: D17472.diff
	Tue, May 7, 11:00 PM

	Unknown Object (File)
	Tue, Apr 30, 11:24 PM

	Unknown Object (File)
	Sun, Apr 28, 10:44 AM

	Unknown Object (File)
	Sat, Apr 27, 1:30 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rP0d12bbb9038c: Set a max-width on crumbs just in case

Summary

Ref D17361. This sets a reasonable width on crumbs just in case a title is super long. Also fixes a weird Safari issue.

Test Plan

Set a username to "hector" and check Safari. Create a badge named "MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM" and test length.

Diff Detail

Repository

rP Phabricator

Branch

long-crumbs (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 15922
Build 21084: Run Core Tests
Build 21083: arc lint + arc unit

Event Timeline

chad created this revision.Mar 6 2017, 6:37 PM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 6 2017, 6:37 PM

Harbormaster completed remote builds in B15922: Diff 42016.Mar 6 2017, 6:39 PM

chad edited the test plan for this revision. (Show Details)Mar 6 2017, 6:39 PM

epriestley accepted this revision.Mar 6 2017, 6:40 PM

This revision is now accepted and ready to land.Mar 6 2017, 6:40 PM

Stack overflow is useful sometimes.

Closed by commit rP0d12bbb9038c: Set a max-width on crumbs just in case (authored by chad, committed by chad). · Explain WhyMar 6 2017, 6:47 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

phui/

phui-crumbs-view.css

11 lines

Diff 42016

View Options

resources/celerity/map.php