Page MenuHomePhabricator

Set a max-width on crumbs just in case
ClosedPublic

Authored by chad on Mar 6 2017, 6:37 PM.
Tags
None
Referenced Files
F19812096: D17472.diff
Wed, Mar 4, 3:37 AM
F19800701: D17472.diff
Sat, Feb 28, 5:32 PM
F19576774: D17472.diff
Feb 1 2026, 9:48 AM
F19571770: D17472.diff
Feb 1 2026, 2:45 AM
F19121295: D17472.id42016.diff
Dec 9 2025, 10:24 PM
F19084071: D17472.id42017.diff
Dec 2 2025, 2:20 PM
F19082104: D17472.id42016.diff
Dec 2 2025, 9:41 AM
F19082103: D17472.id42017.diff
Dec 2 2025, 9:41 AM
Subscribers

Details

Summary

Ref D17361. This sets a reasonable width on crumbs just in case a title is super long. Also fixes a weird Safari issue.

Test Plan

Set a username to "hector" and check Safari. Create a badge named "MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM" and test length.

pasted_file (932×940 px, 93 KB)

pasted_file (1×2 px, 247 KB)

Diff Detail

Repository
rP Phabricator
Branch
long-crumbs (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15922
Build 21084: Run Core Tests
Build 21083: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mar 6 2017, 6:40 PM

Stack overflow is useful sometimes.

This revision was automatically updated to reflect the committed changes.