Page MenuHomePhabricator

Highlight strong tag in document headers
ClosedPublic

Authored by chad on Mar 6 2017, 3:58 PM.
Tags
None
Referenced Files
F15521206: D17469.id42010.diff
Sun, Apr 20, 12:10 PM
F15516299: D17469.id.diff
Fri, Apr 18, 5:47 PM
F15511617: D17469.diff
Thu, Apr 17, 3:37 AM
F15461822: D17469.id.diff
Tue, Apr 1, 11:31 AM
F15450159: D17469.diff
Fri, Mar 28, 2:18 PM
F15431671: D17469.id42011.diff
Mon, Mar 24, 1:51 PM
F15417893: D17469.id42011.diff
Mar 20 2025, 7:13 PM
F15416936: D17469.id42010.diff
Mar 20 2025, 2:25 PM
Subscribers

Details

Summary

Fixes T12357. Adds some color to highlighted text in headers.

Test Plan

Header with strong copy

Diff Detail

Repository
rP Phabricator
Branch
remarkup-header-header-bold-header-bold (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15916
Build 21075: Run Core Tests
Build 21074: arc lint + arc unit

Event Timeline

Maybe try text shadow or text outline (or "font-weight: 90000-super-bold" if that works) or something instead?

  • This communicates information only through use of color.
  • I think we use the "fire" color for dead wiki links already: xxxx; conflating these seems a little confusing.
  • Text shadow feels more "bold-like" to me (making the glyph shapes heavier) than a coloration change.
This revision is now accepted and ready to land.Mar 6 2017, 5:18 PM
This revision was automatically updated to reflect the committed changes.