Page MenuHomePhabricator

Support timeouts for Phage commands
ClosedPublic

Authored by epriestley on Mar 4 2017, 6:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 3:25 AM
Unknown Object (File)
Sun, Feb 9, 3:25 AM
Unknown Object (File)
Sun, Feb 9, 3:25 AM
Unknown Object (File)
Tue, Jan 28, 2:46 AM
Unknown Object (File)
Sat, Jan 25, 4:44 PM
Unknown Object (File)
Fri, Jan 24, 7:26 PM
Unknown Object (File)
Fri, Jan 24, 7:26 PM
Unknown Object (File)
Fri, Jan 24, 7:26 PM
Subscribers
None

Details

Summary

Ref T2794. Occasionally stuff hangs for whatever reason. Provide a crude per-command timeout as a general tool for dealing with this.

Test Plan

Added some sleep and ran with --timeout, saw commands get killed and reported as failed.

Diff Detail

Repository
rPHU libphutil
Branch
phage1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15899
Build 21050: Run Core Tests
Build 21049: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mar 4 2017, 6:11 PM
This revision was automatically updated to reflect the committed changes.