Page MenuHomePhabricator
Differential D17463

Support timeouts for Phage commands
ClosedPublic
Actions

Authored by epriestley on Mar 4 2017, 6:11 PM.
Tags
None
Referenced Files
F15533225: D17463.id.diff
Wed, Apr 23, 6:47 PM
F15467401: D17463.diff
Thu, Apr 3, 2:32 PM
F15465029: D17463.id41996.diff
Wed, Apr 2, 1:52 PM
F15463393: D17463.id41995.diff
Tue, Apr 1, 11:03 PM
F15459070: D17463.id.diff
Mon, Mar 31, 9:35 AM
F15458423: D17463.diff
Mon, Mar 31, 12:29 AM
F15435522: D17463.diff
Tue, Mar 25, 8:45 AM
F15418424: D17463.id41996.diff
Mar 20 2025, 11:14 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T2794: Implement Phage (like Hypershell)
Commits
rPHU796cb1c2ee27: (stable) Promote 2017 Week 9
rPHU13a200ca7621: Support timeouts for Phage commands
Summary

Ref T2794. Occasionally stuff hangs for whatever reason. Provide a crude per-command timeout as a general tool for dealing with this.

Test Plan

Added some sleep and ran with --timeout, saw commands get killed and reported as failed.

Diff Detail

Repository
rPHU libphutil
Branch
phage1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15899
Build 21050: Run Core Tests
Build 21049: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 4 2017, 6:11 PM
chad accepted this revision.Mar 4 2017, 6:11 PM
This revision is now accepted and ready to land.Mar 4 2017, 6:11 PM
Harbormaster completed remote builds in B15899: Diff 41995.Mar 4 2017, 6:11 PM
Closed by commit rPHU13a200ca7621: Support timeouts for Phage commands (authored by epriestley, committed by epriestley). · Explain WhyMar 4 2017, 6:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
phage/
__tests__/
2 lines
action/
2 lines
21 lines
agent/
7 lines

Diff 41995

View Options

src/phage/__tests__/PhageAgentTestCase.php

Loading...
View Options

src/phage/action/PhageAgentAction.php

Loading...
View Options

src/phage/action/PhageExecuteAction.php

Loading...
View Options

src/phage/agent/PhagePHPAgent.php

Loading...
Phabricator · Built by Phacility