Only validate form subtype edits if subtype transactions are present
ClosedPublic
Actions

Authored by epriestley on Mar 3 2017, 9:43 PM.

Tags

None

Referenced Files

	F13365128: D17457.id41981.diff
	Wed, Jun 26, 12:57 PM

	F13364242: D17457.id41980.diff
	Wed, Jun 26, 6:51 AM

	F13357223: D17457.diff
	Mon, Jun 24, 11:17 PM

	F13345054: D17457.diff
	Fri, Jun 21, 9:24 AM

	F13343229: D17457.diff
	Thu, Jun 20, 10:38 PM

	F13311508: D17457.diff
	Tue, Jun 11, 5:05 AM

	F13297634: D17457.diff
	Fri, Jun 7, 5:47 AM

	F13294357: D17457.id41981.diff
	Wed, Jun 5, 5:12 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12314: Support formal task subtypes (like "bug" vs "feature")
T12347: "Make Editable" for any (non-task) form causes exception: "Unable to resolve method 'newEditEngineSubtypeMap'."

Commits

rP5ed90b223591: Only validate form subtype edits if subtype transactions are present

Summary

Fixes T12347. Ref T12314. Validation gets called no matter what, but is only relevant if the form supports subtypes.

Test Plan

Marked/unmarked a Paste form as editable.

Diff Detail

Repository

rP Phabricator

Branch

edit1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15884
Build 21027: Run Core Tests
Build 21026: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 3 2017, 9:43 PM

Harbormaster completed remote builds in B15884: Diff 41980.Mar 3 2017, 9:44 PM

chad accepted this revision.Mar 3 2017, 9:44 PM

This revision is now accepted and ready to land.Mar 3 2017, 9:44 PM

Closed by commit rP5ed90b223591: Only validate form subtype edits if subtype transactions are present (authored by epriestley, committed by epriestley). · Explain WhyMar 3 2017, 9:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editor/

PhabricatorEditEngineConfigurationEditor.php

30 lines

Diff 41980

View Options

src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditor.php

Only validate form subtype edits if subtype transactions are presentClosedPublicActions