Page MenuHomePhabricator

When editing a subtyped object, use edit forms of the same subtype
ClosedPublic

Authored by epriestley on Mar 2 2017, 1:04 AM.
Tags
None
Referenced Files
F15300125: D17445.id.diff
Wed, Mar 5, 4:25 PM
Unknown Object (File)
Sat, Feb 22, 12:08 PM
Unknown Object (File)
Feb 16 2025, 1:14 AM
Unknown Object (File)
Feb 5 2025, 3:28 AM
Unknown Object (File)
Jan 31 2025, 1:29 AM
Unknown Object (File)
Jan 30 2025, 9:44 AM
Unknown Object (File)
Jan 29 2025, 2:18 PM
Unknown Object (File)
Jan 28 2025, 11:21 PM
Subscribers
None

Details

Summary

Ref T12314. When we pick an "Edit" form for a subtyped object, only consider forms with the same subtype.

For example, editing an "Animal" uses the forms with subtype "animal" which are marked as edit forms.

This also makes "Create Subtask" carry the parent task's type.

Test Plan
  • Edited an Animal, got an animal edit form.
  • Edited a normal task, got a normal task form.
  • Edited a paste, got the normal workflow.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable