Page MenuHomePhabricator

When editing a subtyped object, use edit forms of the same subtype
ClosedPublic

Authored by epriestley on Mar 2 2017, 1:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 25, 10:25 AM
Unknown Object (File)
Feb 3 2024, 2:55 PM
Unknown Object (File)
Jan 30 2024, 5:23 PM
Unknown Object (File)
Jan 23 2024, 11:03 AM
Unknown Object (File)
Jan 11 2024, 12:23 PM
Unknown Object (File)
Jan 6 2024, 12:26 AM
Unknown Object (File)
Jan 5 2024, 1:46 PM
Unknown Object (File)
Dec 29 2023, 7:55 PM
Subscribers
None

Details

Summary

Ref T12314. When we pick an "Edit" form for a subtyped object, only consider forms with the same subtype.

For example, editing an "Animal" uses the forms with subtype "animal" which are marked as edit forms.

This also makes "Create Subtask" carry the parent task's type.

Test Plan
  • Edited an Animal, got an animal edit form.
  • Edited a normal task, got a normal task form.
  • Edited a paste, got the normal workflow.

Diff Detail

Repository
rP Phabricator
Branch
subtype7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15846
Build 20968: Run Core Tests
Build 20967: arc lint + arc unit