Put revisions waiting on other reviewers in their own bucket
ClosedPublic
Actions

Authored by epriestley on Feb 27 2017, 6:17 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jul 1, 7:56 PM

	Unknown Object (File)
	Tue, Jun 23, 3:11 AM

	Unknown Object (File)
	Jun 6 2026, 2:02 PM

	Unknown Object (File)
	Jun 6 2026, 1:52 PM

	Unknown Object (File)
	Feb 26 2026, 11:06 PM

	Unknown Object (File)
	Feb 1 2026, 12:07 AM

	Unknown Object (File)
	Jan 14 2026, 11:31 AM

	Unknown Object (File)
	Jan 14 2026, 11:18 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12323: Revisions show in Other Revisions when acceptance status is unclear

Commits

rP6c21646b5f33: Put revisions waiting on other reviewers in their own bucket

Summary

Fixes T12323. See that task for discussion.

Test Plan

Diff Detail

Repository

rP Phabricator

Branch

bucket1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15801
Build 20894: Run Core Tests
Build 20893: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 27 2017, 6:17 PM

chad accepted this revision.Feb 27 2017, 6:18 PM

This revision is now accepted and ready to land.Feb 27 2017, 6:18 PM

Harbormaster completed remote builds in B15801: Diff 41900.Feb 27 2017, 6:18 PM

Closed by commit rP6c21646b5f33: Put revisions waiting on other reviewers in their own bucket (authored by epriestley, committed by epriestley). · Explain WhyFeb 27 2017, 6:47 PM

This revision was automatically updated to reflect the committed changes.

jcarrillo7 mentioned this in T12235: Differential wrongly says I "Must Review" reviews rejected by group.Mar 1 2017, 12:27 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

query/

DifferentialRevisionRequiredActionResultBucket.php

26 lines

Diff 41900

View Options

src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php

Put revisions waiting on other reviewers in their own bucketClosedPublicActions