Page MenuHomePhabricator

When computing revision ownership, cache some intermediate results for performance
ClosedPublic

Authored by epriestley on Feb 27 2017, 4:05 PM.
Tags
None
Referenced Files
F13101341: D17424.id41899.diff
Fri, Apr 26, 11:25 PM
F13098746: D17424.id41893.diff
Fri, Apr 26, 9:49 AM
Unknown Object (File)
Thu, Apr 25, 2:26 AM
Unknown Object (File)
Thu, Apr 25, 2:23 AM
Unknown Object (File)
Tue, Apr 16, 2:41 PM
Unknown Object (File)
Thu, Apr 11, 9:47 AM
Unknown Object (File)
Mon, Apr 8, 10:26 AM
Unknown Object (File)
Mon, Apr 1, 12:18 PM
Subscribers
None

Details

Summary

Ref T12319. With large datasets, the computation of which packages own paths in a revision is needlessly slow.

Improve performance through caching:

  • Cache which paths belong to each repository.
  • Cache the split fragments of each path.
  • Cache the path fragment counts.
  • Micro-optimize accessing $this->path.
Test Plan
  • Used bin/lipsum to generate 4,000 packages with 150,000 paths.
  • Created a revision affecting 100 paths in phabricator/ (these paths mostly overlap with bin/lipsum path rules, since Lipsum uses Phabricator-like rules to generate paths).
  • Before optimizations, this revision spent about 5.5 seconds computing paths.
  • After optimizations, it spends about 275ms.

Screen Shot 2017-02-27 at 8.01.39 AM.png (1×2 px, 375 KB)

Diff Detail

Repository
rP Phabricator
Branch
lipsum6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15794
Build 20886: Run Core Tests
Build 20885: arc lint + arc unit