Page MenuHomePhabricator

Make `bin/lipsum generate` hanldle generator keys and arguments more clearly
ClosedPublic

Authored by epriestley on Feb 27 2017, 12:20 PM.
Tags
None
Referenced Files
F13107257: D17420.diff
Sat, Apr 27, 10:24 PM
Unknown Object (File)
Thu, Apr 25, 1:15 AM
Unknown Object (File)
Wed, Apr 24, 5:03 AM
Unknown Object (File)
Fri, Apr 5, 6:55 PM
Unknown Object (File)
Sat, Mar 30, 3:59 PM
Unknown Object (File)
Mar 22 2024, 10:44 PM
Unknown Object (File)
Mar 20 2024, 1:40 PM
Unknown Object (File)
Feb 9 2024, 2:56 AM
Subscribers
None

Details

Summary

Ref T12319. Currently, bin/lipsum uses substring matches against human-readable text to chose which objects to generate.

Instead:

  • Use separate selector keys which are guaranteed to be unique.
  • When a match is exact, select only that generator.
  • When a match is ambiguous, fail and warn the user.
Test Plan

Generated several types of objects, tried to generate ambiguous objects like "e".

Diff Detail

Repository
rP Phabricator
Branch
lipsum2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15790
Build 20878: Run Core Tests
Build 20877: arc lint + arc unit