Page MenuHomePhabricator

Make `bin/lipsum generate` hanldle generator keys and arguments more clearly
ClosedPublic

Authored by epriestley on Feb 27 2017, 12:20 PM.
Tags
None
Referenced Files
F14886986: D17420.id41895.diff
Sun, Feb 9, 3:23 AM
F14886984: D17420.id41889.diff
Sun, Feb 9, 3:22 AM
F14886982: D17420.id.diff
Sun, Feb 9, 3:22 AM
Unknown Object (File)
Mon, Feb 3, 3:41 AM
Unknown Object (File)
Sun, Feb 2, 5:15 AM
Unknown Object (File)
Fri, Jan 24, 7:21 PM
Unknown Object (File)
Fri, Jan 24, 7:21 PM
Unknown Object (File)
Fri, Jan 24, 7:21 PM
Subscribers
None

Details

Summary

Ref T12319. Currently, bin/lipsum uses substring matches against human-readable text to chose which objects to generate.

Instead:

  • Use separate selector keys which are guaranteed to be unique.
  • When a match is exact, select only that generator.
  • When a match is ambiguous, fail and warn the user.
Test Plan

Generated several types of objects, tried to generate ambiguous objects like "e".

Diff Detail

Repository
rP Phabricator
Branch
lipsum2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15790
Build 20878: Run Core Tests
Build 20877: arc lint + arc unit