Ref T12270. This converts Badges to modular transactions for editing and awarding.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T12270: Unbeta Badges
- Commits
- rP3eae9a368de0: Modular Transactions for Badges
Add Badge, edit badge, award and revoke... Still going to test this some more but feel free to comment on anything obviously wrong?
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- badges-modular-transactions (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 15743 Build 20804: Run Core Tests Build 20803: arc lint + arc unit
Event Timeline
Comment Actions
Nice!
| src/applications/badges/xaction/PhabricatorBadgesBadgeFlavorTransaction.php | ||
|---|---|---|
| 16–22 | I think you can get rid of this completely now since Badges are on EditEngine, should be handled automatically now. | |
| src/applications/badges/xaction/PhabricatorBadgesBadgeIconTransaction.php | ||
| 16–22 | As above, likely obsolete. | |
| src/applications/badges/xaction/PhabricatorBadgesBadgeQualityTransaction.php | ||
| 16–22 | As above, likely obsolete. | |
| 31–44 | These should maaaaaybe use renderValue(...) to pick up the italic style? ModularTransactions generally uses renderValue() for titles, etc. Not sure if we want to count this sort of text as user-provided text or not. | |
| src/applications/badges/xaction/PhabricatorBadgesBadgeStatusTransaction.php | ||
| 27 | Does this need a feed title? | |
| src/applications/badges/xaction/PhabricatorBadgesBadgeTransactionType.php | ||
| 6–8 | Get rid of this, specific to Calendar. | |
Comment Actions
A lot of stuff just worked, so I'm going to re-test everything again because... it seemed too easy?
| src/applications/badges/xaction/PhabricatorBadgesBadgeQualityTransaction.php | ||
|---|---|---|
| 31–44 | I couldn't get that to work? The value is a number. | |
| src/applications/badges/xaction/PhabricatorBadgesBadgeQualityTransaction.php | ||
|---|---|---|
| 31–44 | Oh, sorry, I mean like this? Or did that not work either? $new = $this->getNewValue(); // Raw number, like 3. $new = $this->getQualityLabel($new); // Now a string, like "Rare". $new = $this->renderValue($new); // Now a fancy string, like //Rare//. | |