Paths

Table of Contentst

Differential D17400

Use ApplicationSearch in XHProf
ClosedPublic
Actions

Authored by epriestley on Feb 23 2017, 5:59 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 6, 9:17 PM

	Unknown Object (File)
	Fri, May 3, 2:26 AM

	Unknown Object (File)
	Mon, Apr 29, 1:56 PM

	Unknown Object (File)
	Wed, Apr 24, 10:02 PM

	Unknown Object (File)
	Sun, Apr 21, 4:08 PM

	Unknown Object (File)
	Wed, Apr 17, 3:09 PM

	Unknown Object (File)
	Thu, Apr 11, 7:18 AM

	Unknown Object (File)
	Apr 6 2024, 11:31 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile

Commits

rP425470227193: Use ApplicationSearch in XHProf

Summary

Ref T12297. This slightly modernizes the XHProf UI. Not included here:

Some of the code acts like samples have PHIDs, but they currently do not. I plan to add them in the next change.
I've intentionally left the actual list untouched for now -- it has some old/buggy code (like flag-6 is no longer an icon) that I'll fix in a future change.

Test Plan

Screen Shot 2017-02-23 at 9.56.14 AM.png (1×1 px, 308 KB)

Diff Detail

Repository

Branch

profile2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15736
Build 20794: Run Core Tests
Build 20793: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 23 2017, 5:59 PM

Harbormaster completed remote builds in B15736: Diff 41839.Feb 23 2017, 5:59 PM

Harbormaster completed remote builds in B15736: Diff 41839.

chad accepted this revision.Feb 23 2017, 6:17 PM

This revision is now accepted and ready to land.Feb 23 2017, 6:17 PM

Closed by commit rP425470227193: Use ApplicationSearch in XHProf (authored by epriestley, committed by epriestley). · Explain WhyFeb 23 2017, 7:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

9 lines

applications/

xhprof/

controller/

PhabricatorXHProfSampleListController.php

90 lines

query/

PhabricatorXHProfSampleQuery.php

51 lines

PhabricatorXHProfSampleSearchEngine.php

97 lines

storage/

PhabricatorXHProfSample.php

25 lines

Diff 41839

src/__phutil_library_map__.php

Loading...

src/applications/xhprof/controller/PhabricatorXHProfSampleListController.php

Loading...

src/applications/xhprof/query/PhabricatorXHProfSampleQuery.php

Loading...

src/applications/xhprof/query/PhabricatorXHProfSampleSearchEngine.php

Loading...

src/applications/xhprof/storage/PhabricatorXHProfSample.php

Loading...