Page MenuHomePhabricator

Use ApplicationSearch in XHProf
ClosedPublic

Authored by epriestley on Feb 23 2017, 5:59 PM.
Tags
None
Referenced Files
F14040455: D17400.diff
Mon, Nov 11, 10:26 AM
F14008958: D17400.id.diff
Wed, Oct 30, 8:14 AM
F13987749: D17400.diff
Mon, Oct 21, 11:06 AM
F13986009: D17400.diff
Mon, Oct 21, 12:03 AM
F13974515: D17400.id41839.diff
Fri, Oct 18, 5:57 AM
F13966819: D17400.id41844.diff
Wed, Oct 16, 9:49 AM
F13960581: D17400.id.diff
Tue, Oct 15, 12:09 AM
Unknown Object (File)
Sep 26 2024, 1:23 PM
Subscribers
None

Details

Summary

Ref T12297. This slightly modernizes the XHProf UI. Not included here:

  • Some of the code acts like samples have PHIDs, but they currently do not. I plan to add them in the next change.
  • I've intentionally left the actual list untouched for now -- it has some old/buggy code (like flag-6 is no longer an icon) that I'll fix in a future change.
Test Plan

Screen Shot 2017-02-23 at 9.56.14 AM.png (1×1 px, 308 KB)

Diff Detail

Repository
rP Phabricator
Branch
profile2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15736
Build 20794: Run Core Tests
Build 20793: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Feb 23 2017, 6:17 PM
This revision was automatically updated to reflect the committed changes.