Fix a couple bad fprintf() method calls in Phage
ClosedPublic
Actions

Authored by epriestley on Feb 19 2017, 2:54 PM.

Tags

None

Referenced Files

	F14094934: D17385.id41805.diff
	Mon, Nov 25, 6:30 PM

	Unknown Object (File)
	Fri, Nov 22, 11:17 PM

	Unknown Object (File)
	Fri, Nov 22, 11:17 PM

	Unknown Object (File)
	Fri, Nov 22, 11:00 PM

	Unknown Object (File)
	Fri, Nov 22, 3:15 PM

	Unknown Object (File)
	Fri, Nov 22, 9:22 AM

	Unknown Object (File)
	Wed, Nov 20, 5:20 PM

	Unknown Object (File)
	Sat, Nov 16, 1:12 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T2794: Implement Phage (like Hypershell)

Commits

rPHU2e26268fb854: Fix a couple bad fprintf() method calls in Phage

Summary

Ref T2794. These currently don't do the right thing if you run a command that prints "%" chacters.

Test Plan

Ran some command which outout "%" characters, no more warnings.

Diff Detail

Repository

rPHU libphutil

Branch

phage1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15702
Build 20741: Run Core Tests
Build 20740: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 19 2017, 2:54 PM

Harbormaster completed remote builds in B15702: Diff 41805.Feb 19 2017, 2:54 PM

chad accepted this revision.Feb 19 2017, 5:27 PM

This revision is now accepted and ready to land.Feb 19 2017, 5:27 PM

Closed by commit rPHU2e26268fb854: Fix a couple bad fprintf() method calls in Phage (authored by epriestley, committed by epriestley). · Explain WhyFeb 19 2017, 6:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

phage/

action/

PhageAgentAction.php

4 lines

Diff 41805

View Options

src/phage/action/PhageAgentAction.php

Fix a couple bad fprintf() method calls in PhageClosedPublicActions