Ran phpstan analyze -a autoload.php phabricator/src.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rPa778151f28c1: Fix errors found by PHPStan
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Passed - Unit
Tests Skipped - Build Status
Buildable 15665 Build 20687: Run Core Tests Build 20686: arc lint + arc unit
Event Timeline
| src/applications/calendar/__tests__/CalendarTimeUtilTestCase.php | ||
|---|---|---|
| 10 | This test case is no longer doing anything with $day so I think it can't be right, but I can try to figure that out and follow up. | |
| src/applications/calendar/storage/PhabricatorCalendarExternalInvitee.php | ||
| 13–19 | We should just remove this: it has no callsites and was improperly copy-pasted. This object has no status, inviterPHID, etc., properties, so this code will fatal even with this fix. | |
| src/applications/conpherence/conduit/ConpherenceCreateThreadConduitAPIMethod.php | ||
| 53–55 | I think this case can just be removed instead. Conpherence threads are no longer required to have a title (if they don't, we'll create a default one by listing the participants) and I think this just never got cleaned up. ERROR_EMPTY_MESSAGE should be impossible when creating a thread and I think it only refs to sending an empty message to an existing thread. | |
Comment Actions
Address feedback
| src/applications/calendar/__tests__/CalendarTimeUtilTestCase.php | ||
|---|---|---|
| 10 | I've changed it to getTimestamps($u, $day, 1) and the test now passes. | |
| src/applications/calendar/storage/PhabricatorCalendarExternalInvitee.php | ||
| 13–19 | Note that it returns PhabricatorCalendarEventInvitee, not PhabricatorCalendarExternalInvitee. I'll submit it like this and let you follow up. | |
| src/applications/conpherence/conduit/ConpherenceCreateThreadConduitAPIMethod.php | ||
| 53–55 | Removed. | |