Paths

Table of Contentst

Remove unused class "PhutilConsoleConcatenatedView"
ClosedPublic
Actions

Authored by epriestley on Feb 16 2017, 12:47 PM.

Tags

None

Referenced Files

	F15419686: D17365.id41759.diff
	Fri, Mar 21, 8:03 AM

	F15418314: D17365.id41759.diff
	Thu, Mar 20, 10:29 PM

	F15413366: D17365.diff
	Wed, Mar 19, 6:17 PM

	F15411673: D17365.id.diff
	Wed, Mar 19, 9:31 AM

	F15409568: D17365.id41759.diff
	Wed, Mar 19, 4:42 AM

	F15408559: D17365.diff
	Tue, Mar 18, 11:51 PM

	F15400049: D17365.id.diff
	Mon, Mar 17, 9:21 AM

	F15385107: D17365.id41757.diff
	Fri, Mar 14, 9:43 PM

View All Files

Subscribers

None

Details

Reviewers

vrana
chad

Commits

rPHUe78b0df10881: Remove unused class "PhutilConsoleConcatenatedView"

Summary

See D14136. This class is never used anywhere and wouldn't work anyway.

I believe the thing it was intended to do (merging views into a single string) ended up in the base class, PhutilConsoleView.

Test Plan

Grepped for PhutilConsoleConcatenatedView in libphutil, Arcanist, and Phabricator.

Diff Detail

Repository

rPHU libphutil

Branch

rm1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15653
Build 20668: Run Core Tests
Build 20667: arc lint + arc unit

Event Timeline

Also arc liberate.

Harbormaster failed remote builds in B15652: Diff 41756!Feb 16 2017, 12:48 PM

vrana accepted this revision.Feb 16 2017, 12:48 PM

This revision is now accepted and ready to land.Feb 16 2017, 12:48 PM

Harbormaster completed remote builds in B15653: Diff 41757.Feb 16 2017, 12:49 PM

Closed by commit rPHUe78b0df10881: Remove unused class "PhutilConsoleConcatenatedView" (authored by epriestley, committed by epriestley). · Explain WhyFeb 16 2017, 12:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

console/

view/

PhutilConsoleConcatenatedView.php

Diff 41757

View Options

src/__phutil_library_map__.php