Remove unused class "PhutilConsoleConcatenatedView"
ClosedPublic
Actions

Authored by epriestley on Feb 16 2017, 12:47 PM.

Details

Reviewers

vrana
chad

Commits

rPHUe78b0df10881: Remove unused class "PhutilConsoleConcatenatedView"

Summary

See D14136. This class is never used anywhere and wouldn't work anyway.

I believe the thing it was intended to do (merging views into a single string) ended up in the base class, PhutilConsoleView.

Test Plan

Grepped for PhutilConsoleConcatenatedView in libphutil, Arcanist, and Phabricator.

Diff Detail

Repository

rPHU libphutil

Branch

rm1

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 15652
Build 20666: Run Core Tests
Build 20665: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	37 ms	PhutilLibraryTestCase::Unknown Unit Message ("") EXCEPTION (PhutilBootloaderException): Include of '/core/data/drydock/workingcopy-75/repo/libphutil/src/console/view/PhutilConsoleConcatenatedView.php' failed! #0 /core/data/drydock/workingcopy-75/repo/libphutil/src/symbols/PhutilSymbolLoader.php(381): PhutilBootloader->loadLibrarySource('phutil', 'console/view/Ph...') #1 /core/data/drydock/workingcopy-75/repo/libphutil/src/symbols/PhutilSymbolLoader.php(256): PhutilSymbolLoader->loadSymbol(Array)
	2 ms	PhutilLibraryTestCase::Unknown Unit Message ("") EXCEPTION (PhutilBootloaderException): Include of '/core/data/drydock/workingcopy-75/repo/libphutil/src/console/view/PhutilConsoleConcatenatedView.php' failed! #0 /core/data/drydock/workingcopy-75/repo/libphutil/src/symbols/PhutilSymbolLoader.php(381): PhutilBootloader->loadLibrarySource('phutil', 'console/view/Ph...') #1 /core/data/drydock/workingcopy-75/repo/libphutil/src/symbols/PhutilSymbolLoader.php(256): PhutilSymbolLoader->loadSymbol(Array)
	607 ms	PhutilLibraryTestCase::Unknown Unit Message ("") Assertion failed, expected 'true' (at PhutilLibraryTestCase.php:51): The library map is out of date. Rebuild it with `arc liberate`. These entries differ: class.PhutilConsoleConcatenatedView, xmap.PhutilConsoleConcatenatedView.
	1 ms	AbstractDirectedGraphTestCase::Unknown Unit Message ("") 25 assertions passed.
	0 ms	AbstractDirectedGraphTestCase::Unknown Unit Message ("") 1 assertion passed.
		View Full Test Results (3 Failed · 328 Passed · 2 Skipped)