Page MenuHomePhabricator

Restrict movable panels to non-tab panels
ClosedPublic

Authored by chad on Feb 14 2017, 10:11 PM.
Tags
None
Referenced Files
F19220304: D17356.id41738.diff
Wed, Dec 17, 10:57 AM
F18864768: D17356.id.diff
Nov 3 2025, 8:37 AM
F18840920: D17356.diff
Oct 28 2025, 5:01 AM
F18804293: D17356.id41737.diff
Oct 18 2025, 7:14 AM
F18779807: D17356.diff
Oct 11 2025, 3:29 PM
F18757104: D17356.id41737.diff
Oct 5 2025, 3:37 PM
F18638713: D17356.diff
Sep 17 2025, 11:23 AM
F18093201: D17356.id41738.diff
Aug 7 2025, 4:19 PM
Subscribers

Details

Summary

Fixes T12248. Adds a flag for movable panels, and only allows those to be moved. Also cleaned up some CSS rules missing once a panel was drug into a new position.

Test Plan

Try to drag a tab panel content pane, cannot. Drag normal pane, see CSS, grab and drag same panel back, CSS looks the same.

Diff Detail

Repository
rP Phabricator
Branch
drag-tab (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15633
Build 20634: Run Core Tests
Build 20633: arc lint + arc unit