Page MenuHomePhabricator

Restrict movable panels to non-tab panels
ClosedPublic

Authored by chad on Feb 14 2017, 10:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 12, 9:47 PM
Unknown Object (File)
Wed, Feb 12, 9:59 AM
Unknown Object (File)
Wed, Feb 12, 9:29 AM
Unknown Object (File)
Sun, Feb 9, 3:17 AM
Unknown Object (File)
Sun, Feb 9, 3:17 AM
Unknown Object (File)
Sun, Feb 9, 3:17 AM
Unknown Object (File)
Sun, Feb 9, 3:17 AM
Unknown Object (File)
Sat, Feb 8, 4:01 PM
Subscribers

Details

Summary

Fixes T12248. Adds a flag for movable panels, and only allows those to be moved. Also cleaned up some CSS rules missing once a panel was drug into a new position.

Test Plan

Try to drag a tab panel content pane, cannot. Drag normal pane, see CSS, grab and drag same panel back, CSS looks the same.

Diff Detail

Repository
rP Phabricator
Branch
drag-tab (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 15633
Build 20634: Run Core Tests
Build 20633: arc lint + arc unit